Skip to content

Update markdown-it version#19417

Merged
mjbvz merged 1 commit intomicrosoft:masterfrom
katainaka0503:updateMarkdownItVersion
Jan 27, 2017
Merged

Update markdown-it version#19417
mjbvz merged 1 commit intomicrosoft:masterfrom
katainaka0503:updateMarkdownItVersion

Conversation

@katainaka0503
Copy link
Contributor

Update the version of markdown-it in markdown extension from 6.0.1 to 8.2.2.

@mention-bot
Copy link

@katainaka0503, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jrieken and @Tyriar to be potential reviewers.

@msftclas
Copy link

Hi @katainaka0503, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@msftclas
Copy link

Hi @katainaka0503, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.

TTYL, MSBOT;

@Tyriar
Copy link
Member

Tyriar commented Jan 26, 2017

This is 2 major version jumps which could mean this introduces breakages. Here's the change log https://github.com/markdown-it/markdown-it/blob/master/CHANGELOG.md

@mjbvz
Copy link
Collaborator

mjbvz commented Jan 27, 2017

@katainaka0503 Thank you for the contribution.

Let's hold off on merging this in until next week. We're just about to ship 1.9 and I want this sort of change to have more testing in insiders builds before it goes out officially

@mjbvz mjbvz self-requested a review January 27, 2017 00:26
@mjbvz mjbvz merged commit e68ab66 into microsoft:master Jan 27, 2017
@mjbvz mjbvz mentioned this pull request Jan 27, 2017
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants