Fixes #18999 - Added .npmignore as a known file type#19387
Merged
joaomoreno merged 1 commit intomicrosoft:masterfrom Feb 6, 2017
Merged
Fixes #18999 - Added .npmignore as a known file type#19387joaomoreno merged 1 commit intomicrosoft:masterfrom
joaomoreno merged 1 commit intomicrosoft:masterfrom
Conversation
|
@chirag64, thanks for your PR! By analyzing the history of the files in this pull request, we identified @joaomoreno and @bpasero to be potential reviewers. |
|
Hi @chirag64, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
Member
|
Awesome, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18999 by adding .npmignore as a known file type in the registry entries so that they get the correct icon.
Can anyone help me test this change though? Running 'scripts\npm install' doesn't seem like it is triggering the registry entry installation.