[Git] Migrate to git autostash when pulling for better performance#187850
[Git] Migrate to git autostash when pulling for better performance#187850lszomoru merged 6 commits intomicrosoft:mainfrom
Conversation
|
Thank you very much for the pull request and apologies for not getting back to you on this until now. The |
|
@lszomoru why close? why don't ask me to preserve the existing functionality for Git prior 2.27 , I believe most of the vscode users have a newer version of Git installed. I think it makes sense to use features when they are available. I think not doing it because of the 1% of users who have some old version of git installed is not reasonable IMO (sorry I'm not sure of 1% actually, but this version is really old). |
I fully agree with taking advantage of new git functionality but by doing so we should not break existing functionality for users that are using older versions of VS Code. There are multiple places in the |
|
ok thanks, sorry im on vacation right now, I did put on my track, will do in a few weeks |
|
@zardoy, no rush. Enjoy your vacation. |
ok thanks but should be ready now |
lszomoru
left a comment
There was a problem hiding this comment.
Thank you very much for making the changes.
I left some comments, could you please take a look?
|
@zardoy, I hope you don't mind but I pushed a commit to the PR implementing the changes that I have requested. |
No, you are the best, thank you for saving this pr! I'm so sorry as workdays started I became really busy I'm so sorry for not responding for the comment above in a reasonable time |
|
@zardoy, no worries. Thanks for pushing to get this change in. |
fixes #180426
AFAIK Builtin --autostash option never stash everything, also, obviously it won't create stash if not needed.