Skip to content

Dispose TerminalWordLinkDetector listeners#187083

Merged
Tyriar merged 2 commits intomicrosoft:mainfrom
SvanT:main
Jul 6, 2023
Merged

Dispose TerminalWordLinkDetector listeners#187083
Tyriar merged 2 commits intomicrosoft:mainfrom
SvanT:main

Conversation

@SvanT
Copy link
Copy Markdown
Contributor

@SvanT SvanT commented Jul 5, 2023

Fixes #187082

Copy link
Copy Markdown
Contributor

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Tyriar Tyriar added this to the July 2023 milestone Jul 5, 2023
@Tyriar Tyriar enabled auto-merge July 5, 2023 22:20
@SvanT
Copy link
Copy Markdown
Contributor Author

SvanT commented Jul 6, 2023

@Tyriar it seems like the yarn.lock check won't run for some reason, blocking the merge?

@Tyriar Tyriar closed this Jul 6, 2023
auto-merge was automatically disabled July 6, 2023 13:45

Pull request was closed

@Tyriar Tyriar reopened this Jul 6, 2023
@Tyriar Tyriar enabled auto-merge July 6, 2023 13:45
@Tyriar
Copy link
Copy Markdown
Contributor

Tyriar commented Jul 6, 2023

Sometimes they get stuck

@Tyriar Tyriar merged commit 94cfd18 into microsoft:main Jul 6, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TerminalWordLinkDetector leaks memory

3 participants