Skip to content

fix fish shell integration problems#185907

Merged
meganrogge merged 1 commit intomainfrom
merogge/mode-prompt
Jun 22, 2023
Merged

fix fish shell integration problems#185907
meganrogge merged 1 commit intomainfrom
merogge/mode-prompt

Conversation

@meganrogge
Copy link
Collaborator

fix #185750

Issue 1:

  • Move function invocation below function definitions

Issue 2:

  • When fish_mode_prompt is defined, put __vsc_fish_cmd_start in that instead of fish_prompt so shell integration works

@meganrogge meganrogge requested a review from Tyriar June 22, 2023 19:00
@meganrogge
Copy link
Collaborator Author

Your review would be great @mkhl

@vscodenpa vscodenpa added this to the June 2023 milestone Jun 22, 2023
Copy link
Contributor

@mkhl mkhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@meganrogge meganrogge merged commit 3cc13d7 into main Jun 22, 2023
@meganrogge meganrogge deleted the merogge/mode-prompt branch June 22, 2023 22:39
@github-actions github-actions bot locked and limited conversation to collaborators Aug 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fish: Unknown command: __init_vscode_shell_integration

4 participants