respect fish_prompt, re-enable automatic fish shell integration#185355
Merged
meganrogge merged 12 commits intomainfrom Jun 20, 2023
Merged
respect fish_prompt, re-enable automatic fish shell integration#185355meganrogge merged 12 commits intomainfrom
fish_prompt, re-enable automatic fish shell integration#185355meganrogge merged 12 commits intomainfrom
Conversation
This reverts commit e37dcc5.
meganrogge
commented
Jun 16, 2023
...kbench/contrib/terminal/browser/media/fish_xdg_data/fish/vendor_conf.d/shellIntegration.fish
Outdated
Show resolved
Hide resolved
Tyriar
previously requested changes
Jun 16, 2023
Member
…59"" This reverts commit fdf30c9.
meganrogge
force-pushed
the
merogge/fish-s
branch
from
1971db8 to
c618245
Compare
mkhl
approved these changes
Jun 18, 2023
Contributor
mkhl
left a comment
mkhl
left a comment
There was a problem hiding this comment.
Super tiny nits but LGTM!
(I don't love duplicating the default fish prompt but can't see a way around it)
...kbench/contrib/terminal/browser/media/fish_xdg_data/fish/vendor_conf.d/shellIntegration.fish
Outdated
Show resolved
Hide resolved
...kbench/contrib/terminal/browser/media/fish_xdg_data/fish/vendor_conf.d/shellIntegration.fish
Outdated
Show resolved
Hide resolved
mjbvz
approved these changes
Jun 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #139400