Skip to content

Restore ShellIntegration for fish (#184659)#184739

Merged
meganrogge merged 1 commit intomicrosoft:mainfrom
max06:max06/issue184659
Jun 13, 2023
Merged

Restore ShellIntegration for fish (#184659)#184739
meganrogge merged 1 commit intomicrosoft:mainfrom
max06:max06/issue184659

Conversation

@max06
Copy link
Contributor

@max06 max06 commented Jun 9, 2023

Resolves #184659

The output for the cli command code --locate-shell-integration-path fish now returns the path to the current location of the shellIntegration-script for the fish-shell.

⚠️ This is untested code. I tried building vscode for 3 hours now, in codespaces and in a local devcontainer, without success.

Copy link

@danielstephan-bosch danielstephan-bosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm this works on my machine.

@meganrogge meganrogge enabled auto-merge June 12, 2023 20:34
@meganrogge meganrogge requested a review from Tyriar June 12, 2023 20:34
@Tyriar Tyriar added this to the June 2023 milestone Jun 13, 2023
@meganrogge meganrogge merged commit 8a4ebd7 into microsoft:main Jun 13, 2023
meganrogge added a commit that referenced this pull request Jun 13, 2023
meganrogge added a commit that referenced this pull request Jun 16, 2023
meganrogge added a commit that referenced this pull request Jun 16, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ShellIntegration for fish is gone

4 participants