Fixes #177580#177581
Merged
Merged
Conversation
Contributor
|
I think this is a breaking change. |
Contributor
Author
|
Very much sensible. However I think it is such a special API that if someone is using it, they should have the deepest understanding of the theme settings. And those people are probably reading the release notes to their fullest. |
aeschli
previously approved these changes
Mar 23, 2023
Contributor
|
It is a breaking change but the |
alexr00
approved these changes
Mar 23, 2023
TylerLeonhardt
approved these changes
Mar 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know that spell check PRs are not welcomed, but this one is a public API that has a spell checking problem and honestly it needs to be fixed