Don't scroll sync to elements inside collapsed details sections#176541
Merged
mjbvz merged 2 commits intomicrosoft:mainfrom Mar 8, 2023
Merged
Don't scroll sync to elements inside collapsed details sections#176541mjbvz merged 2 commits intomicrosoft:mainfrom
mjbvz merged 2 commits intomicrosoft:mainfrom
Conversation
Fixes microsoft#176538 Turns out that `getClientBoundingRect` returns weird bounds for elements inside of a collapsed details section
Tyriar
approved these changes
Mar 8, 2023
aeschli
approved these changes
Mar 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #176538
Turns out that
getClientBoundingRectreturns weird bounds for elements inside of a collapsed details section