keep the accessible buffer visible until tab/escape are used#176054
Merged
meganrogge merged 23 commits intomainfrom Mar 3, 2023
Merged
keep the accessible buffer visible until tab/escape are used#176054meganrogge merged 23 commits intomainfrom
tab/escape are used#176054meganrogge merged 23 commits intomainfrom
Conversation
meganrogge
commented
Mar 3, 2023
Tyriar
suggested changes
Mar 3, 2023
src/vs/workbench/contrib/terminal/browser/xterm/xtermTerminal.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminal/browser/xterm/xtermTerminal.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminal/browser/xterm/xtermTerminal.ts
Outdated
Show resolved
Hide resolved
Tyriar
reviewed
Mar 3, 2023
meganrogge
commented
Mar 3, 2023
Collaborator
Author
|
there's an issue now because tabbing goes to the status bar instead of the terminal. I see that |
meganrogge
force-pushed
the
merogge/acc-re
branch
from
368c661 to
95b0e48
Compare
Tyriar
reviewed
Mar 3, 2023
src/vs/workbench/contrib/terminalContrib/accessibility/browser/terminalAccessibleBuffer.ts
Outdated
Show resolved
Hide resolved
Tyriar
previously requested changes
Mar 3, 2023
...rkbench/contrib/terminalContrib/accessibility/browser/terminal.accessibility.contribution.ts
Outdated
Show resolved
Hide resolved
...rkbench/contrib/terminalContrib/accessibility/browser/terminal.accessibility.contribution.ts
Outdated
Show resolved
Hide resolved
...rkbench/contrib/terminalContrib/accessibility/browser/terminal.accessibility.contribution.ts
Outdated
Show resolved
Hide resolved
...rkbench/contrib/terminalContrib/accessibility/browser/terminal.accessibility.contribution.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminalContrib/accessibility/browser/terminalAccessibleBuffer.ts
Show resolved
Hide resolved
…/terminalAccessibleBuffer.ts Co-authored-by: Daniel Imms <[email protected]>
connor4312
approved these changes
Mar 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #175764
fixes #175765
fixes #176065