Add themeable color for comment glyphs on lines with unresolved threads#174915
Conversation
|
/assign @alexr00 |
hermannloose
force-pushed
the
comment-glyph-color
branch
from
da432ca to
3b3699c
Compare
|
Friendly ping. |
|
@hermannloose I will try to look this week! |
hermannloose
force-pushed
the
comment-glyph-color
branch
from
a05c1d4 to
0391629
Compare
|
Another friendly ping. 😊 I was also wondering whether it's generally preferred to use merge instead of rebase + force-push for keeping a PR up to date; I noticed that the comment from John earlier resulted in a broken link for a while (but I cannot reproduce that now) after I had addressed the changes and force-pushed. |
|
Merge is usually preferred for keeping PRs up to date if you think someone else might check out the PR branch (and we often check out PR branches to test changes). |
alexr00
left a comment
alexr00
left a comment
There was a problem hiding this comment.
Thank you for your patience with my slowness in reviewing this change! I've fixed the nits so that we can merge this sooner.
| export const editorGutterCommentGlyphForeground = registerColor('editorGutter.commentGlyphForground', { dark: editorForeground, light: editorForeground, hcDark: Color.black, hcLight: Color.white }, nls.localize('editorGutterCommentGlyphForeground', 'Editor gutter decoration color for commenting glyphs.')); | ||
| export const editorGutterCommentUnresolvedGlyphForeground = registerColor('editorGutter.commentUnresolvedGlyphForeground', { dark: editorGutterCommentGlyphForeground, light: editorGutterCommentGlyphForeground, hcDark: editorGutterCommentGlyphForeground, hcLight: editorGutterCommentGlyphForeground }, nls.localize('editorGutterCommentUnresolvedGlyphForeground', 'Editor gutter decoration color for commenting glyphs for unresolved comment threads.')); |
There was a problem hiding this comment.
It looks like neither of these need to be exported as they aren't used outside this file. editorGutterCommentUnresolvedGlyphForeground isn't used anywhere and doesn't need to be saved to a const at all.
There was a problem hiding this comment.
I've made the changes so that we can get this merged today.
4 participants
As a follow-up to #174418 which decorated lines with unresolved comment threads with the
comment-unresolvedicon, we would like the option to distinguish by color as well. Our users request this especially in cases where the comment is collapsed, to quickly spot lines with actionable comments.