composition enter should not accept rename#174829
Merged
Merged
Conversation
lawvs
force-pushed
the
fix/rename-composing
branch
3 times, most recently
from
7da38e4 to
3c07818
Compare
lawvs
force-pushed
the
fix/rename-composing
branch
from
3c07818 to
3cbe13e
Compare
jrieken
approved these changes
Mar 16, 2023
Contributor
jrieken
left a comment
jrieken
left a comment
There was a problem hiding this comment.
Thanks. This is a great fix
bpasero
approved these changes
Mar 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the issue where pressing enter while using CJK input method triggers unexpected confirmation of rename operation, which may also result in malfunctioning of rename operation.
Screen.Recording.2023-02-20.at.7.14.17.PM.mov