Add custom path for vscode-server socket files and named pipe length#172481
Add custom path for vscode-server socket files and named pipe length#172481bpasero merged 4 commits intomicrosoft:mainfrom
Conversation
|
Let's discuss in #172480 (comment) |
bpasero
left a comment
bpasero
left a comment
There was a problem hiding this comment.
I do not really understand this change. The comment indicates this helps on Windows, but this change is for macOS/Linux?
Besides, the only consumer of this method is this it seems:
As such, the type is always going to be short (main) and the version at least for stable will be short as well (1.75.0).
Am I missing something?
|
Our version string is longer than 1.75.0 (we use date based versions which end up extending this beyond the limit). So in your the case of public VS Code, this wouldn't have an effect but it does for us. If you feel this doesn't make sense to upstream given the way the public product is versioned, we can keep this fork on our end. |
|
I see. Still, this change has no impact on Windows right? So what problem does this address? |
|
Apologies on the comment, I went backwards. :( windows returns early from this function with their named pipe which works fine. but there's a limit on macos and linux for the name of the .sock file which ends up getting too long with our additional versioning. This is related to the stackexchange comment in the original issue. |
|
Ok understood, setting to March for consideration. |
bpasero
left a comment
bpasero
left a comment
There was a problem hiding this comment.
Actually I think this is good to go even for Feb.
4 participants
Change for #172480
For socket file name length we scope version to 4 characters and type to 6 characters and have found that works great for Windows.
This has been tested and validated in our environment to remove issues related to ensuring windows named pipes are resilient to variable name length.