Skip to content

Added features and fixes to screencast mode#171845

Merged
joaomoreno merged 9 commits into
microsoft:mainfrom
webarthur:main
Mar 9, 2023
Merged

Added features and fixes to screencast mode#171845
joaomoreno merged 9 commits into
microsoft:mainfrom
webarthur:main

Conversation

@webarthur
Copy link
Copy Markdown
Contributor

  • Fix annoying arrow key repetition in screencast mode
  • Fix label of pressed arrow keys in screencast mode
  • Add option to hide single arrow keys pressed in screencast mode

@webarthur
Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree [company="{your company}"]

@webarthur
Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree

@joaomoreno joaomoreno changed the title Added some features and fixes to screencast mode Added features and fixes to screencast mode Jan 26, 2023
Comment thread src/vs/workbench/browser/actions/developerActions.ts Outdated
Comment thread src/vs/workbench/browser/actions/developerActions.ts Outdated
@dominik-ba
Copy link
Copy Markdown

So will this be merged? :)

@pbarhyl
Copy link
Copy Markdown

pbarhyl commented Mar 9, 2023

Also waiting for that!

@joaomoreno
Copy link
Copy Markdown
Member

joaomoreno commented Mar 9, 2023

I only understood now that the setting is about not showing the commands used to move the text editor cursor. It's not about arrow keys per se... since a user can customize the keyboard shortcuts for the cursor move commands.

@joaomoreno joaomoreno added this to the March 2023 milestone Mar 9, 2023
@joaomoreno joaomoreno enabled auto-merge (squash) March 9, 2023 16:17
@joaomoreno joaomoreno merged commit a5df3bd into microsoft:main Mar 9, 2023
@dominik-ba
Copy link
Copy Markdown

Maybe its only me, but at least I now get a pop up for each key that I type although I enabled the flag to show only on keyboard shortcuts

@github-actions github-actions Bot locked and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants