Merged
Conversation
Member
Author
|
@meganrogge this is ready for a review, I'd like to get it in asap so I can start doing smaller incremental changes and track things in issues. Everything is behind a new setting so it should be fairly safe. It's not worth doing a big review of the suggest stuff as it's mostly a fork with parts commented out, which will get cleaned up later. |
meganrogge
previously approved these changes
Jan 19, 2023
meganrogge
previously approved these changes
Jan 19, 2023
meganrogge
approved these changes
Jan 19, 2023
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of ##154662
It's a bit rough around the edges currently but it's behind the
terminal.integrated.shellIntegration.suggestEnabledsettingAfter chatting with @jrieken and further thinking, this is the approach I'm taking for the workbench suggest widget:
workbench/services/suggestwill extend theeditor/suggestwhere trivial, otherwise things will be forked. This will make the review/abstraction/etc. burden oneditor/suggestlow.If it makes sense to avoid editor components in certain parts of
editor/suggestlater, we could move some to platform. That's not that important from my perspective though.