Skip to content

#162727: 'Debug:Run to cursor' command is now available in inactive d…#169819

Merged
roblourens merged 7 commits intomicrosoft:mainfrom
Viijay-Kr:feat-#162727-debug-run-to-cursor-while-inactive
Jan 31, 2023
Merged

#162727: 'Debug:Run to cursor' command is now available in inactive d…#169819
roblourens merged 7 commits intomicrosoft:mainfrom
Viijay-Kr:feat-#162727-debug-run-to-cursor-while-inactive

Conversation

@Viijay-Kr
Copy link
Copy Markdown
Contributor

@Viijay-Kr Viijay-Kr commented Dec 22, 2022

Addresses the feature requested in #162727

This PR took the strategy mentioned in this comment

Refactorings

  1. The debuggerService.runTo is refactored to support inactive debugger state
  2. Two closures have been added to handle add and remove temp breakpoints.
  3. Remove breakpoints is attached to the listeners in the both the cases (Stopped and Inactive blocks)

@Viijay-Kr
Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree

@Viijay-Kr Viijay-Kr force-pushed the feat-#162727-debug-run-to-cursor-while-inactive branch 2 times, most recently from 124bed3 to 609760b Compare December 22, 2022 15:04
Comment thread src/vs/workbench/contrib/debug/browser/debugEditorActions.ts Outdated
@Viijay-Kr Viijay-Kr force-pushed the feat-#162727-debug-run-to-cursor-while-inactive branch 3 times, most recently from 8c3d057 to b7bd2c6 Compare January 9, 2023 16:27
@Viijay-Kr Viijay-Kr force-pushed the feat-#162727-debug-run-to-cursor-while-inactive branch from b7bd2c6 to e483823 Compare January 10, 2023 08:03
@roblourens roblourens added this to the January 2023 milestone Jan 13, 2023
Copy link
Copy Markdown
Member

@roblourens roblourens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@roblourens
Copy link
Copy Markdown
Member

Sorry, I missed getting a second review for this, and ran out of time for this release. I'll be sure to merge it next week for the February release.

@roblourens roblourens closed this Jan 31, 2023
@roblourens roblourens reopened this Jan 31, 2023
@roblourens roblourens merged commit 62dd7cd into microsoft:main Jan 31, 2023
@Viijay-Kr Viijay-Kr deleted the feat-#162727-debug-run-to-cursor-while-inactive branch January 31, 2023 14:25
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants