Skip to content

Support some links with spaces#169786

Merged
Tyriar merged 6 commits intomainfrom
tyriar/space_link
Dec 22, 2022
Merged

Support some links with spaces#169786
Tyriar merged 6 commits intomainfrom
tyriar/space_link

Conversation

@Tyriar
Copy link
Member

@Tyriar Tyriar commented Dec 21, 2022

Supported:

  • Python style links: From "<path>", line <line>
  • Lines that only contain a path: <path>
  • Independently styled file paths: foo<underlined_path>bar

Fixes #97941

@Tyriar Tyriar added this to the January 2023 milestone Dec 21, 2022
@Tyriar Tyriar self-assigned this Dec 21, 2022
@Tyriar Tyriar marked this pull request as draft December 21, 2022 23:32
@Tyriar Tyriar marked this pull request as ready for review December 21, 2022 23:40
Copy link
Contributor

@DonJayamanne DonJayamanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to have a simple unit test to ensure we don't regress here.

@Tyriar
Copy link
Member Author

Tyriar commented Dec 22, 2022

Was thinking that while working on these improvements. I might do a follow up but right now it's difficult to test the links that need to test the file paths.

@Tyriar Tyriar merged commit d251600 into main Dec 22, 2022
@Tyriar Tyriar deleted the tyriar/space_link branch December 22, 2022 05:03
@bromelio
Copy link

bromelio commented Dec 22, 2022

Please also include the following error line format in the fix:

C:\[any number of subfolders]\Program.cpp(18,29) : error 135: '}' - unexpected token

...where 18 is the line number where the error occurred (and where one would therefore like to jump to via clicking the error line).

Thank you!

@Tyriar
Copy link
Member Author

Tyriar commented Dec 22, 2022

@bromelio what compiler is that from?

Tyriar added a commit that referenced this pull request Dec 22, 2022
@Tyriar
Copy link
Member Author

Tyriar commented Dec 22, 2022

@bromelio done in #169850

image

@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support path links that contain spaces in the integrated terminal

3 participants