Support opening external uris in terminal links#168641
Merged
Conversation
rebornix
previously requested changes
Dec 9, 2022
Member
rebornix
left a comment
rebornix
left a comment
There was a problem hiding this comment.
test for "Change for request"
joyceerhl
reviewed
Dec 9, 2022
src/vs/workbench/contrib/terminal/browser/links/terminalWordLinkDetector.ts
Outdated
Show resolved
Hide resolved
joyceerhl
reviewed
Dec 9, 2022
src/vs/workbench/contrib/terminal/browser/links/terminalWordLinkDetector.ts
Outdated
Show resolved
Hide resolved
joyceerhl
reviewed
Dec 12, 2022
src/vs/workbench/contrib/terminal/browser/links/terminalWordLinkDetector.ts
Outdated
Show resolved
Hide resolved
joyceerhl
previously approved these changes
Dec 12, 2022
joyceerhl
approved these changes
Dec 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #158810
@joyceerhl would you be able to test this? I want to make sure it works and it's the safe way of doing this.