Adding Docker 1.12 instructions to its grammar#16476
Merged
aeschli merged 1 commit intomicrosoft:masterfrom Dec 5, 2016
lostintangent:patch-1
Merged
Adding Docker 1.12 instructions to its grammar#16476aeschli merged 1 commit intomicrosoft:masterfrom lostintangent:patch-1
aeschli merged 1 commit intomicrosoft:masterfrom
lostintangent:patch-1
Conversation
This simply updates the Docker grammar to include the `HEALTHCHECK` and `SHELL` commands that were added to Docker 1.12, and were added to the [grammar file](https://github.com/docker/docker/blob/4cb71f80823af345d063cf0ad657e73ce9caa75f/contrib/syntax/textmate/Docker.tmbundle/Syntaxes/Dockerfile.tmLanguage) which VS Code's copy is based on.
|
Hi @lostintangent, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
Contributor
|
Thanks @lostintangent ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simply updates the Docker grammar to include the
HEALTHCHECKandSHELLcommands which were introduced to Docker 1.12, and were added to the grammar file that VS Code's copy is based on.Note that the alpha-sorting of the command names represents the majority of the code churn, and was done in order to sync with the aforementioned grammar in the Docker GitHub repo.