Skip to content

Fix comma splices in descriptions in src/vs/workbench/contrib/terminal/common/terminalConfiguration.ts#164401

Merged
Tyriar merged 9 commits into
microsoft:mainfrom
hughlilly:comma-splice-fixes
Oct 24, 2022
Merged

Fix comma splices in descriptions in src/vs/workbench/contrib/terminal/common/terminalConfiguration.ts#164401
Tyriar merged 9 commits into
microsoft:mainfrom
hughlilly:comma-splice-fixes

Conversation

@hughlilly

Copy link
Copy Markdown
Contributor

This PR suggests a number of grammatical fixes in src/vs/workbench/contrib/terminal/common/terminalConfiguration.ts, mostly to remedy comma splices.

@hughlilly

Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree

meganrogge
meganrogge previously approved these changes Oct 24, 2022
@meganrogge
meganrogge requested a review from Tyriar October 24, 2022 19:24
@meganrogge meganrogge added this to the October 2022 milestone Oct 24, 2022
Tyriar
Tyriar previously approved these changes Oct 24, 2022

@Tyriar Tyriar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL I often use comma splices 👀

@Tyriar
Tyriar enabled auto-merge October 24, 2022 19:49
auto-merge was automatically disabled October 24, 2022 20:29

Head branch was pushed to by a user without write access

@hughlilly
hughlilly dismissed stale reviews from Tyriar and meganrogge via c22980c October 24, 2022 20:29
@hughlilly

Copy link
Copy Markdown
Contributor Author

Sorry, I think I might have made a mistake here; I was trying to add another commit.

@Tyriar
Tyriar merged commit f95bfda into microsoft:main Oct 24, 2022
@hughlilly
hughlilly deleted the comma-splice-fixes branch October 24, 2022 21:31
formigoni pushed a commit to formigoni/vscode that referenced this pull request Oct 27, 2022
Fix comma splices in descriptions in `src/vs/workbench/contrib/terminal/common/terminalConfiguration.ts`
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants