Scroll webview to top if unmatched fragment is #top#164070
Merged
Merged
Conversation
mjbvz
reviewed
Oct 19, 2022
dsanders11
force-pushed
the
webview-top-fragment
branch
from
October 19, 2022 23:59
2d556e7 to
1c75fd9
Compare
mjbvz
approved these changes
Oct 20, 2022
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the HTML Standard, section 7.11.9 “Navigating to a fragment” states that when looking for the indicated part of the document, if the fragment doesn’t match any element, but is the special value “top”, then the top of the document is indicated:
This PR updates the logic for webviews to follow the spec. Can be tested by putting a link to
#topin a Markdown document and previewing the document.cc @mjbvz