Don't depend on typescript protocol.d.ts#163365
Merged
mjbvz merged 1 commit intomicrosoft:mainfrom Oct 12, 2022
Merged
Conversation
1 task
ec7dc98 to
a839ccc
Compare
mjbvz
approved these changes
Oct 12, 2022
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For TS 5.0, we're making some major build changes and package cleanups stemming from our conversion from namespaces to modules. protocol.d.ts is one file I'm trying to eliminate, as it's tricky to produce in the new build. See also:
Rather than using this a d.ts file, we can depend on the same namespace as exported by
tsserverlibraryinstead, a file that is definitely not going away.This actually reveals a couple of interesting things:
protocolnamespace was being used in a couple places where it shouldn't have been.