Add keyboard shortcuts for scrolling horizontally#162992
Merged
Merged
Conversation
sumon1991
approved these changes
Oct 8, 2022
Member
|
Thank you! |
alexdima
approved these changes
Oct 24, 2022
lramos15
approved these changes
Oct 24, 2022
formigoni
pushed a commit
to formigoni/vscode
that referenced
this pull request
Oct 27, 2022
* Initial horizontal scroll * Use columns as unit in horizontal scrolling shortcuts * Horizontal scroll value 2, remove shortcuts * Unify Horizontal, Vertical scroll Directions and Units, determine the method Co-authored-by: Alexandru Dima <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #143466
CursorConfigurationfontInfoas a dependencyfontInfoto determine the lineHeight instead of getting it explicitly (removes lineHeight dependency).fontInfoto determine thetypicalHalfwidthCharacterWidthCoreNavigationCommandsEditorScrollImpl.runCoreEditorCommandinstead ofEditorScrollImpl._runEditorScrolland passEditorScroll_.RawArgumentsEditorScroll_.UnitandEditorScroll_.DirectionEditorScrollImpl.runCoreEditorCommanddetermines the scrolling method from the direction and the unit if they are compatibleColumn(typicalHalfwidthCharacterWidth).scrollLeftandscrollRightscroll two columns (this more or less matches the pace of the vertical scroll)scrollable;typicalHalfwidthCharacterWidthis usually a float while integer values are forced in theviewLayout's scrollableargs.revealCursoris still not implemented