Merged
Conversation
- Bump copyright year xtermjs/xterm.js#4176 - Share texture atlas cache code between webgl and canvas renderers xtermjs/xterm.js#4170 - Add willReadFrequently to canvas renderer too xtermjs/xterm.js#4169 - Ensure texture atlas comparison uses rgba not object xtermjs/xterm.js#4168 - Create new event with emitter object to simplify code xtermjs/xterm.js#4166 - Define all events and emitters consistently xtermjs/xterm.js#4165 - Inline dirty row service into input handler xtermjs/xterm.js#4163 - Move w objects to $ prefix variables xtermjs/xterm.js#4162 Fixes #158984 Fixes #158874
Contributor
Author
|
Need to fix an internal API access issue |
meganrogge
previously approved these changes
Oct 6, 2022
Contributor
Author
|
Blocked on xtermjs/xterm.js#4177 |
This includes a revert to event refactor which will fix vscode's internal access. It was going to be reverted anyway.
meganrogge
approved these changes
Oct 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #158984
Fixes #158874
#4166from Tyriar/event_with_emitter" Revert "Merge pull request #4166 from Tyriar/event_with_emitter" xtermjs/xterm.js#4177