Enforce yarn version#162610
Merged
Merged
Conversation
Actually require >=1.10.1 and <2
joaomoreno
approved these changes
Oct 5, 2022
aeschli
approved these changes
Oct 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #162609.
Actually requires >=1.10.1 and <2, but was only enforcing >= 1 or >= x.10. Granted, there is no yarn v3.10 yet, but there may be someday. And if it actually requires >=1.10.1 (and not just >=1.10.0) as the error states, it should enforce that as well.
I initially mimicked the node.js version checking code, which only gives a warning if node.js >= 17, but now I'm not sure that makes sense, as yarn >= 2 will always fail without changes to support it. For example, build/lib/dependencies.ts relies on
yarn list, which is not in yarn >=2, it would need to detect this and support the usage ofyarn infoas a substitute. (I'm sure there are many more changes that would be needed, that's just an example, I didn't dig too deep)I pushed a 2nd commit to instead error on yarn >= 2.