# Provide correct response to applyEdit()#162430
Merged
Merged
Conversation
Contributor
Author
jrieken
suggested changes
Oct 3, 2022
jrieken
approved these changes
Oct 4, 2022
aeschli
approved these changes
Oct 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment
vscode.workspace.applyEdit()returns alwaystrue, regardless whether the WorkspaceEdit was applied/discarded.To provide a better feedback to the extensions relying on this signal, add a boolean property
isAppliedwhich would betrueif at least one ResourceEdit has been applied. If none has been applied, no edit has been provided or discard has been pressed thenfalsewould be returned back.This change should not impact existing functionality as only
src/vs/workbench/contrib/notebook/browser/diff/notebookDiffActions.tsreturn back the result frombulkEditService.applyEdit()directly to callers ofnotebook.diff.cell.revertInputso the calling extensions (as its not called in VScode) should be able to continue functioning without any problems (as they would either rely on the result being undefined, or extracting theariaSummary).fixes #161133