fix: preserve process.execArgv#161853
Merged
Merged
Conversation
This ensures flags like `--prof` are passed down to the vs code process so we can profile everything. To test this: 1. run `./lib/node --prof .` 2. in another terminal, run `ps -ejww` You should see `--prof` next to every vs code process.
Contributor
Author
|
@alexdima any update on this? happy to open an issue if you'd like more context first. |
sandy081
approved these changes
Oct 24, 2022
formigoni
pushed a commit
to formigoni/vscode
that referenced
this pull request
Oct 27, 2022
This ensures flags like `--prof` are passed down to the vs code process so we can profile everything. To test this: 1. run `./lib/node --prof .` 2. in another terminal, run `ps -ejww` You should see `--prof` next to every vs code process.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures flags like
--profare passed down to the vs code process so we can profile everything.To test this:
./lib/node --prof .ps -ejwwYou should see
--profnext to every vs code process.P.S. this approach leans on a pattern already in the codebase:
vscode/src/vs/base/parts/ipc/node/ipc.cp.ts
Lines 198 to 200 in 06bd7ae