Fix backslash is not escaped by define key binding#16108
Merged
alexdima merged 1 commit intomicrosoft:masterfrom Dec 5, 2016
Merged
Fix backslash is not escaped by define key binding#16108alexdima merged 1 commit intomicrosoft:masterfrom
alexdima merged 1 commit intomicrosoft:masterfrom
Conversation
|
@ypresto, thanks for your PR! By analyzing the history of the files in this pull request, we identified @alexandrudima, @jrieken and @joaomoreno to be potential reviewers. |
|
Hi @ypresto, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
ypresto
changed the title
ypresto
force-pushed
the
fix-define-keybinding-escape
branch
from
85a2835 to
8cf8206
Compare
Member
|
@ypresto Nice! Thank you for the contribution! ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When defining keybinding using backslash key (with Define Keybinding feature), it will insert unescaped backslash:
This PR fixes it!