Skip to content

Modify "*WordPart*" family of commands to respect kebab-case (resolves #158667)#158672

Merged
alexdima merged 4 commits into
microsoft:mainfrom
nikita-r:nikita-r/158667-fixWordPart
Oct 24, 2022
Merged

Modify "*WordPart*" family of commands to respect kebab-case (resolves #158667)#158672
alexdima merged 4 commits into
microsoft:mainfrom
nikita-r:nikita-r/158667-fixWordPart

Conversation

@nikita-r

@nikita-r nikita-r commented Aug 20, 2022

Copy link
Copy Markdown
Contributor

Fixes #158667

Fixes this family of commands to behave as expected for kebab-case-variables when the "editor.wordSeparators" setting does not include "-"; tests included.
image

@ghost

ghost commented Aug 20, 2022

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@nikita-r nikita-r changed the title Modify "*WordPart*" family of commands to respect kebab-case (#158667) Modify "*WordPart*" family of commands to respect kebab-case (resolves #158667) Aug 20, 2022
@jrieken jrieken assigned alexdima and unassigned jrieken Sep 8, 2022

@alexdima alexdima left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see #158667 (comment)

alexdima
alexdima previously approved these changes Oct 24, 2022
@alexdima alexdima added this to the October 2022 milestone Oct 24, 2022
@alexdima
alexdima merged commit 6399d03 into microsoft:main Oct 24, 2022
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cursorWordPartLeft doesn't stop at - when it is excluded from editor.wordSeparators

6 participants