Fixes detaching a terminal editor doesn't fire vscode.window.onDidCloseTerminal event#154546
Merged
Conversation
meganrogge
reviewed
Oct 6, 2022
meganrogge
previously approved these changes
Oct 6, 2022
Tyriar
approved these changes
Oct 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #152785
First PR got reverted because #153486 . I tried reproducing it but couldn't 🤦
From the stack trace Alex posted it looks like an exception in xterm while being disposed
Cannot read properties of undefined (reading 'marker'): TypeError: Cannot read properties of undefined (reading 'marker')in DecorationServiceSo I added a try catch in the meantime to swallow the exception and the onDisposed event gets fired successfully
cc @Tyriar