@the-ress, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bpasero, @egamma and @joaomoreno to be potential reviewers.

@the-ress can you elaborate a bit what SetAppDetailsForWindow does in the end?

SetAppDetailsForWindow sets these properties for the window (if they're not empty):

• AppUserModel.ID - This needs to be set. Otherwise the other properties are ignored.
• RelaunchIconResource - Icon for the taskbar button and the 'launch new instance' taskbar menu item.
• RelaunchCommand - Command started by the 'launch new instance' menu item.
• RelaunchDisplayNameResource - Label for the 'launch new instance' menu item.

Relaunch command and display name must always be set together. Otherwise neither is used.

@the-ress is there an example of an application that leverages this? if I right click on Chrome for example, I am not seeing a relaunch command.

This is what I see when I right click Chrome:

Regular Chrome window doesn't override the relaunch command so it just launches chrome.exe without any arguments.

However if I run a chrome app, it opens a in new window that is owned by the same chrome.exe, but it changes its taskbar icon, name and relaunch command (using SetAppDetailsForWindow).

The relaunch commands is set to something like chrome.exe --profile-directory=Default --app-id=ibhkjcfebdanponjgchgcgilkoahbpfh. So when I middle-click the button (or shift+click, pin it or click the relaunch menu item), it opens the app and not a regular browser window.

@the-ress that is pretty cool. So what your PR actually fixes is that middle click on the task bar icon opens a new window (something many people have asked for and which I was never sure how to do actually).

Yes. (I referenced the issue in the title of this PR.)

The electron part of this was released in electron 1.4.11.

Thanks for letting me know 👍

Please make sure this PR plays nicely with hot exit, see #48 (comment)

This needs to be addressed on Linux as well.

@Tyriar not sure it is fair to ask for this in the same PR, maybe we should have a separate PR for the Linux problem.

I added a new CLI arg --new-window-if-not-first which should work for Windows if that's the arg the shortcut uses. #48 (comment)

I think the new argument will not help in this case, see #48 (comment)

Optimistically merging this for April since we plan to land Electron 1.6.x.