Add command to copy output of the last command (#152097)#153235
Merged
Conversation
meganrogge
reviewed
Jul 6, 2022
| const commands = cmdDetection?.commands; | ||
| if (commands && commands.length > 0) { | ||
| const output = commands[commands.length - 1]?.getOutput(); | ||
| if (output) { |
Collaborator
There was a problem hiding this comment.
getOutput will return undefined if the last command that was run is in the scrollback, so I don't think this will work for the case you're interested in
Contributor
There was a problem hiding this comment.
It should only be if it's trimmed from the scrollback, so if the command decoration is there it should always have getOutput().
Tyriar
approved these changes
Jul 6, 2022
Contributor
Tyriar
left a comment
Tyriar
left a comment
There was a problem hiding this comment.
Thanks @MonadChains, it worked great. I added some minor tweaks and checked hasOutput before getOutput as well.
Will merge this after #154220 goes in for the conflict
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #152097