Inherit more settings during extension development#151872
Merged
connor4312 merged 1 commit intomicrosoft:mainfrom Aug 3, 2022
Merged
Inherit more settings during extension development#151872connor4312 merged 1 commit intomicrosoft:mainfrom
connor4312 merged 1 commit intomicrosoft:mainfrom
Conversation
Contributor
Author
|
Should |
Member
|
I think this is reasonable, thanks for the PR. I would agree with |
Member
|
@r3m0t were you interested in updating this PR to inherit |
r3m0t
force-pushed
the
issue-143601-ext-dev-reload
branch
from
ccd29ab to
f397e3f
Compare
Contributor
Author
|
@connor4312 I've updated it |
connor4312
approved these changes
Aug 2, 2022
bpasero
approved these changes
Aug 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #143601
Note, there are no tests covering this if statement (I commented it out and nothing failed!)
Testing: launch VS Code
Install third party extension if none is already installed
Open folder helloworld-sample from https://github.com/microsoft/vscode-extension-samples
Edit launch.json adding
"--disable-extensions",toargsRun "Run Extension" task, Extension Development Host opens
Note third party extension is listed and disabled in Extensions view
File>Open Folder in Extension Development Host
Note third party extension is still listed and disabled in Extensions view