add conditional to rpm spec to test for arch, fixes 13616#15128
Merged
Tyriar merged 1 commit intomicrosoft:masterfrom Nov 7, 2016
Merged
add conditional to rpm spec to test for arch, fixes 13616#15128Tyriar merged 1 commit intomicrosoft:masterfrom
Tyriar merged 1 commit intomicrosoft:masterfrom
Conversation
libXss.so.1 was recently introduced as a dependency for correct rpm installation of vscode. libXss.so.1 is a requirement for runtime. this conditional check will help tooling such as yum/dnf/rpm etc ensure the proper dependency is in place at installation time and help avoid bringing in i386 dependency libraries for x86_64 architectures. i386 libXss.so.1 x86_64 libXss.so.1()(64bit)
|
@polygotdev, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Tyriar and @astitcher to be potential reviewers. |
|
Hi @polygotdev, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
Member
|
Thanks for this @polygotdev! It should be available in the Insiders build tomorrow and I've added verification needed to the issue #13616 so it gets tested before the released 🎆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of testing can be viewed at the gist
https://gist.github.com/polygotdev/8610fff8d0c0419c0b22215850517433#file-readme-md
Additional changes should be considered in the future for the glibc dependency but for now this is a minimal change.