Skip to content

Fix DecorationAddon being disposed of immediately#150046

Merged
Tyriar merged 3 commits intomainfrom
tyriar/149866
May 20, 2022
Merged

Fix DecorationAddon being disposed of immediately#150046
Tyriar merged 3 commits intomainfrom
tyriar/149866

Conversation

@Tyriar
Copy link
Copy Markdown
Contributor

@Tyriar Tyriar commented May 20, 2022

Regressed in #148972

Fixes #149866
Fixes #149757

@Tyriar Tyriar added this to the May 2022 milestone May 20, 2022
@Tyriar Tyriar requested a review from meganrogge May 20, 2022 18:40
@Tyriar Tyriar self-assigned this May 20, 2022
Copy link
Copy Markdown
Collaborator

@meganrogge meganrogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱 makes sense

@Tyriar Tyriar enabled auto-merge May 20, 2022 19:34
@Tyriar Tyriar merged commit 8d15d2f into main May 20, 2022
@Tyriar Tyriar deleted the tyriar/149866 branch May 20, 2022 19:46
@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Terminal decorations aren't working properly Terminal Shell Integration Smoke Test Failure

2 participants