Update xterm and make term find styles consistent with editor#149486
Merged
Update xterm and make term find styles consistent with editor#149486
Conversation
- A bunch of changes to xterm.js including bg/fg decoration overrides - Tweak find colors to use background instead of border, align with the editor - Change high contrast themes to also align, including selection bg - Clear the find active result decoration on blur and when the selection changes Fixes #147013 Fixes #145751
Tyriar
commented
May 13, 2022
| "vscode-textmate": "7.0.1", | ||
| "xterm": "4.19.0-beta.29", | ||
| "xterm-addon-search": "0.9.0-beta.26", | ||
| "xterm": "4.19.0-beta.41", |
Contributor
Author
There was a problem hiding this comment.
@meganrogge this probably includes fixes for other vscode issues that should be closed.
Collaborator
|
Seeing some weirdness with the find background/foreground. Looks like it happens when I switch themes with some text selected.
|
Contributor
Author
|
Clarified offline the weirdness above was due to not updating xterm* modules |
meganrogge
approved these changes
May 13, 2022
daviddossett
approved these changes
May 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #147013
Fixes #145751
Fixes #149495
Dark+
Light+
HC Dark
HC Light - Note the black text will be light after xtermjs/xterm.js#3720 is done