Conversation
Tyriar
suggested changes
May 9, 2022
Collaborator
Author
|
I tried to add telemetry for when there are custom args so shell integration injection doesn't occur, but couldn't get it to work with:
|
meganrogge
commented
May 16, 2022
meganrogge
commented
May 16, 2022
meganrogge
commented
May 16, 2022
meganrogge
commented
May 16, 2022
src/vs/workbench/contrib/terminal/browser/xterm/xtermTerminal.ts
Outdated
Show resolved
Hide resolved
meganrogge
commented
May 16, 2022
Tyriar
suggested changes
May 16, 2022
src/vs/workbench/contrib/terminal/browser/xterm/xtermTerminal.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Daniel Imms <[email protected]>
Tyriar
previously approved these changes
May 16, 2022
src/vs/workbench/contrib/terminal/browser/xterm/xtermTerminal.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Daniel Imms <[email protected]>
Tyriar
approved these changes
May 17, 2022
wannieman98
pushed a commit
to wannieman98/vscode
that referenced
this pull request
May 17, 2022
add telemetry for shell integration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #148840