Fix #147912 (multipleSessionWarning debug option)#147914
Conversation
d574251 to
cbce288
Compare
|
Can anyone review this PR or provide feedback? :) |
|
Sorry for letting this slip through the cracks. I guess having this as a launch config option, rather than a user/workspace setting makes sense since there might be a particular launch config that you want to start multiple times? I will take a look at this next week for July. |
|
It might make sense to make this option through the user/workspace setting 🤔 |
|
Not sure about the checkbox, where we have options like that it usually stores it in some hidden state and does not write to a launch config |
|
Yes. The checkbox is an option for user/workspace or "hidden" location settings, not a launch configuration property. I just said that I would try to explore this option as well (in another PR). |
|
Feel free to explore it, but I'm not sure how I feel about that option, would take some thinking |
|
This looks good, but I'm out of the office and will merge it for August. |
|
@roblourens I am not a biggest fan of adding these "UI" settings to the launch.json. A better approach would probably be a setting. And yes I know that then it is not launch config specific, but I am worried if we keep it in a launch.json nobody will find it. So a dialog + checkbox that writes to a setting is the way to go imho. |
|
To me, it's similar to the |
* Fix #147912 (multipleSessionWarning debug option) * Fix #147912 (suppressMultipleSessionWarning debug option) * Fix description and condition Co-authored-by: Rob Lourens <[email protected]>
Add new launch config debug option for silent
'{0}' is already running. Do you want to start another instance?confirm dialog.Tested with simple launch config:
This PR fixes #147912