Skip to content

Add more granularity to terminal find theming, add HC support#145930

Merged
Tyriar merged 4 commits intomainfrom
tyriar/145744
Mar 23, 2022
Merged

Add more granularity to terminal find theming, add HC support#145930
Tyriar merged 4 commits intomainfrom
tyriar/145744

Conversation

@Tyriar
Copy link
Copy Markdown
Contributor

@Tyriar Tyriar commented Mar 23, 2022

Fixes #145744
Fixes #145742
Fixes #145746

image
image
image

@Tyriar Tyriar added this to the March 2022 milestone Mar 23, 2022
@Tyriar Tyriar requested a review from meganrogge March 23, 2022 22:47
@Tyriar Tyriar self-assigned this Mar 23, 2022
Copy link
Copy Markdown
Collaborator

@meganrogge meganrogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@Tyriar Tyriar merged commit 0e81c95 into main Mar 23, 2022
@Tyriar Tyriar deleted the tyriar/145744 branch March 23, 2022 23:16
gabritto pushed a commit to gabritto/vscode that referenced this pull request Mar 25, 2022
Add more granularity to terminal find theming, add HC support
gabritto pushed a commit to gabritto/vscode that referenced this pull request Mar 25, 2022
Add more granularity to terminal find theming, add HC support
gabritto pushed a commit to gabritto/vscode that referenced this pull request Mar 29, 2022
Add more granularity to terminal find theming, add HC support
@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support high contrast find highlighting in terminal Contrast isn't great in find results Find match results are too dim

2 participants