Skip to content

use decorations for terminal find#145628

Merged
Tyriar merged 18 commits intomainfrom
merogge/find
Mar 22, 2022
Merged

use decorations for terminal find#145628
Tyriar merged 18 commits intomainfrom
merogge/find

Conversation

@meganrogge
Copy link
Copy Markdown
Collaborator

This PR fixes #134790

}

private _updateFindColors(searchOptions: ISearchOptions): void {
let selectedColor = this._configurationService.getValue('workbench.colorCustomizations.editor.findMatchBackground');
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aligns with what the editor does - can create an issue if we want to allow setting these for the terminal

@meganrogge meganrogge requested a review from Tyriar March 21, 2022 22:48
@meganrogge meganrogge self-assigned this Mar 21, 2022
@meganrogge meganrogge added this to the March 2022 milestone Mar 21, 2022
@Tyriar Tyriar merged commit 4b92538 into main Mar 22, 2022
@Tyriar Tyriar deleted the merogge/find branch March 22, 2022 00:26
@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Terminal Find: Highlight all instances of term in current viewport and don't manipulate selection

2 participants