Skip to content

Skip reading file content for undo when deleting a large file #144890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jrieken merged 1 commit into from
Mar 16, 2022
Merged

Skip reading file content for undo when deleting a large file #144890

jrieken merged 1 commit into from
Mar 16, 2022

Conversation

@pjknkda
Copy link
Contributor

@pjknkda pjknkda commented Mar 11, 2022

This PR fixes #144889.

@mjbvz mjbvz assigned jrieken and unassigned mjbvz Mar 11, 2022
jrieken
jrieken approved these changes Mar 16, 2022
View reviewed changes
Copy link
Member

@jrieken jrieken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrieken jrieken added this to the March 2022 milestone Mar 16, 2022
@jrieken jrieken merged commit dc0e0ba into microsoft:main Mar 16, 2022
@jrieken
Copy link
Member

jrieken commented Mar 16, 2022

Thanks @pjknkda

@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jrieken jrieken jrieken approved these changes

Assignees

@jrieken jrieken

Labels

triage-needed

Projects

None yet

Milestone

March 2022

Development

Successfully merging this pull request may close these issues.

Unnecessary file content reading when deleting a file

4 participants

@pjknkda @jrieken @mjbvz @vscode-triage-bot