Consider order fields when doing searches in the Settings editor #144213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roblourens
approved these changes
Mar 9, 2022
Consider the category when filtering through settings.
rzhao271
force-pushed
the
rzhao271/settings-search-order
branch
from
67a3b55 to
c065fad
Compare
Collaborator
Author
|
Rebased |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #143513
This PR allows for the
orderfields of settings and categories to be preserved when users do a search, unless the matches have different match types, such as if one of the matches is a whole word match and the other one isn't.Previously, the
orderfields would only be considered when the user was not doing a search.For example, for the screencap below, the settings are in the order C A B (from the B configuration), then D E F (from the A configuration). Even after searching for "Setting", that order is still preserved, which is what we want.