-
Notifications
You must be signed in to change notification settings - Fork 37.1k
Add Fold Jumping (Parent and Next/Previous at Same Level) #128450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Current line to parent fold. - Current line to previous fold at the same level. - Current line to next fold at the same level.
|
Thanks for the great PR! Only concert is the shortcut which is uncommon and collides with existing usages on the Mac. |
|
Thanks for reviewing this so quickly, @aeschli. I removed the shortcut. Please let me know if you have other ideas for what the shortcut should be. |
|
Thanks a lot @ssigwart ! |
|
I've released the PR without shortcuts for now. Happy to add some, if we get non-conflicting ones. |
|
Thanks for merging it, @aeschli. I notice a few checks failed saying they were cancelled. Do I need to do anything with them? |
|
I think this is because I merged without waiting for the last CI build to complete. But all tests pass, nothing anymore to do. |
|
For consistency I'll rename the command from 'Jump' to 'Go to` |
|
Thanks, @aeschli. That makes sense. |
This adds 3 keyboard shortcuts to jump between folds.
By restricting the previous and next folds to the current level. It makes it easy to navigate the different cases of
if/elsestatements.This PR fixes #91023.
I updated the unit test for this. You can also test by opening a file with folds and try out the keyboard shortcuts.