Preserve files on exit (aka hot exit)#12400
Merged
Conversation
Make content update trigger after dirty status is evaluated
79bfa37 to
3387b6c
Compare
The dep can't be fulfilled on main process
2 tasks
Also clean up shutdown logic to fix issue where backup workspaces were not being evicted from workspaces.json.
Member
Author
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening this now to more easily track changes during development.
Fixes #101
TODO
Feedback Round 1
BackupServicebetween the main and renderer processes (fixed in c280e0c)BackupServicetovs/platform/backup/node/(fixed in 3387b6c)Clean up
console.logstatementsKnown issues/follow ups
this.setDirty(true);inTextFileEditorModel.loadnode/fileService.tsintobackupService.ts