Merged
Conversation
Member
|
Just committed, should get released soon microsoft/node-pty@6cf84b7 |
Member
|
@meganrogge has tested for hours and works great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #71966
@Tyriar if you can update the module to use worker script from
node_modules.asar.unpackedthen this should be good to go, I was not sure if you want to make a generic change to the module to accept script path for the worker or you want to add a vscode specific change like below.Have verified with a local vscode packaged build and also sample app https://gist.github.com/deepak1556/c441a82a932a7b72ff8ae6d12e1ee622. What was causing the error previously was the missing file
lib/shared/conout.jsin the unpacked folder that is used byconoutSocketWorkerFixes #71966
Fixes #117956
Fixes #121336