Allow extension authors to set the title of a QuickPick/InputBox in Options#119144
Merged
Conversation
TylerLeonhardt
commented
Mar 17, 2021
TylerLeonhardt
force-pushed
the
TylerLeonhardt/issue77423
branch
2 times, most recently
from
March 17, 2021 17:43
f7a272c to
877c45a
Compare
rheh
approved these changes
Mar 17, 2021
chrmarti
approved these changes
Mar 18, 2021
TylerLeonhardt
force-pushed
the
TylerLeonhardt/issue77423
branch
from
March 18, 2021 17:34
877c45a to
d8ede3b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #77423
naturally if you don't specify a title, then no title bar shows up.
I was looking for an opportunity to write tests for this where I call the showInputBox or whatever and then check if the created input box behind the scenes has the title set... but that looks pretty convoluted so I'm not sure that test is worth it. Please let me know if there's a good way to write a test for this.