Skip to content

Conversation

@kachick
Copy link

@kachick kachick commented Mar 14, 2021

This PR fixes just a typo, I found it in rubyide/vscode-ruby#709
If this change is not needed, please close this PR 🙏

@alexr00
Copy link
Member

alexr00 commented Mar 25, 2021

@kachick thank you for the PR! However, we pull this file from an upstream repo with a script, so the next time that script is run your change would get overwritten. If you want to make this change, please consider making a PR to the upstream repo.

"information_for_contributors": [
"This file has been converted from https://github.com/textmate/ruby.tmbundle/blob/master/Syntaxes/Ruby.plist",
"If you want to provide a fix or improvement, please create a pull request against the original repository.",
"Once accepted there, we are happy to receive an update request."
],

@alexr00 alexr00 closed this Mar 25, 2021
@kachick
Copy link
Author

kachick commented Mar 25, 2021

@alexr00 Yes, I already did it in textmate/ruby.tmbundle#138. It is merged. So I should just wait for script is run?

@kachick kachick deleted the fix-extention-ruby-typo branch March 25, 2021 14:28
@alexr00
Copy link
Member

alexr00 commented Mar 25, 2021

Ah, I didn't read carefully enough! I'll be running the script to pull grammar changes next week so the change will come in then.

@kachick
Copy link
Author

kachick commented Mar 25, 2021

Thank you for the updating plan! 🙏

BTW... https://github.com/textmate/ruby.tmbundle was root repository, but looks not active than VSCode community for now. 😅
Don't you plan to import syntaxes from other active extensions? An example, https://github.com/rubyide/vscode-ruby 🤔

@alexr00
Copy link
Member

alexr00 commented Mar 25, 2021

@kachick since there are rarely issues with the ruby grammar we have no plans to change which repo we get our grammar from.

@kachick
Copy link
Author

kachick commented Mar 25, 2021

Hmm... Sure! Thanks for the answer! 🙏

@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants