-
Notifications
You must be signed in to change notification settings - Fork 36.9k
Fix typo s/precidence/precedence/ #118923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@kachick thank you for the PR! However, we pull this file from an upstream repo with a script, so the next time that script is run your change would get overwritten. If you want to make this change, please consider making a PR to the upstream repo. vscode/extensions/ruby/syntaxes/ruby.tmLanguage.json Lines 2 to 6 in 3f1f363
|
|
@alexr00 Yes, I already did it in textmate/ruby.tmbundle#138. It is merged. So I should just wait for |
|
Ah, I didn't read carefully enough! I'll be running the script to pull grammar changes next week so the change will come in then. |
|
Thank you for the updating plan! 🙏 BTW... https://github.com/textmate/ruby.tmbundle was root repository, but looks not active than VSCode community for now. 😅 |
|
@kachick since there are rarely issues with the ruby grammar we have no plans to change which repo we get our grammar from. |
|
Hmm... Sure! Thanks for the answer! 🙏 |
This PR fixes just a typo, I found it in rubyide/vscode-ruby#709
If this change is not needed, please close this PR 🙏