Prevent error when reopening markdown preview. (#107205)#111449
Merged
mjbvz merged 1 commit intomicrosoft:masterfrom Dec 1, 2020
Merged
Prevent error when reopening markdown preview. (#107205)#111449mjbvz merged 1 commit intomicrosoft:masterfrom
mjbvz merged 1 commit intomicrosoft:masterfrom
Conversation
Devansh2005
approved these changes
Nov 29, 2020
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default to active group instead of throwing error when calling
editorGroupToViewColumn(). This fix makes markdown previews behave like text editors when reopening. The error was caused when the preview was opened in an editor group that has since closed.I am not sure why @sohomdatta1 solution was not accepted but here is another attempt.
Fixes #107205