Add vscode.Uri to types for vscode.RelativePattern's base parameter#111155
Merged
bpasero merged 1 commit intomicrosoft:masterfrom Nov 24, 2020
Merged
Add vscode.Uri to types for vscode.RelativePattern's base parameter#111155bpasero merged 1 commit intomicrosoft:masterfrom
bpasero merged 1 commit intomicrosoft:masterfrom
Conversation
jrieken
reviewed
Nov 24, 2020
| * relative to the base path. | ||
| */ | ||
| constructor(base: WorkspaceFolder | string, pattern: string) | ||
| constructor(base: Uri | WorkspaceFolder | string, pattern: string) |
Member
There was a problem hiding this comment.
jsdoc tag seems outdated (already before this change)
| if (typeof base === 'string') { | ||
| this.base = base; | ||
| } else if (URI.isUri(base)) { | ||
| this.baseFolder = base; |
Member
There was a problem hiding this comment.
Why is this a baseFolder? Also, what is baseFolder and is it API creep? It's not declared in vscode.d.ts
Member
|
Will follow up, the questions are relevant even before this change and originate from a change I did: 782c941 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #111154.
It's a little more than just syntactic sugar, since using a
vscode.Uriwill setbaseFolderwhich means the path doesn't need to be re-parsed back into avscode.Uri, as is done in a couple parts of the codebase ifbaseFolderis not set.