Prompt user with info about terminal config, add settings search by @id, and add sendToShell setting#110987
Merged
roblourens merged 18 commits intomasterfrom Nov 23, 2020
Merged
Conversation
meganrogge
changed the title
roblourens
reviewed
Nov 20, 2020
src/vs/workbench/contrib/preferences/browser/settingsTreeModels.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminal/common/terminalConfiguration.ts
Outdated
Show resolved
Hide resolved
…efService instead of commandService and use set.has
roblourens
reviewed
Nov 21, 2020
Member
roblourens
left a comment
roblourens
left a comment
There was a problem hiding this comment.
Built this and tried it out and I'm wondering, maybe I should only ever see this notification once. It's really easy to trigger, and my muscle memory is just to press escape when I want it to go away. Then I end up seeing it over and over.
src/vs/workbench/contrib/preferences/browser/settingsTreeModels.ts
Outdated
Show resolved
Hide resolved
Member
|
You don't have to keep merging master into your PR, unless there are conflicts to resolve or some new change that you want to base this on. |
65 tasks
Collaborator
Author
@roblourens made this change |
meganrogge
force-pushed
the
merogge/terminal-settings
branch
from
a8e6a2e to
8fe20e8
Compare
roblourens
reviewed
Nov 23, 2020
roblourens
reviewed
Nov 23, 2020
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use @id: to search for one or more comma separated settings ids
Use keyboard shortcuts on the terminal corresponding to
terminal.integrated.commandsToSkipShellcommands and see an alert to configure terminal settings. ClickingConfigureorDon't show againshould result in never seeing the prompt again as the same user. Clicking the x on the prompt will show the prompt again the next time it's triggered.Set
terminal.integrated.sendToShell: true and use any key-bindings that trigger something to happen in the terminal. They should work and not be handled by the workbench. For example, Ctrl+E should jump to the end of the line instead of opening the quick pick.You should still be able to use Ctrl+1-9 to navigate around the editor groups.